SALVAGE AID MACRO 1.6.0.0

NEW VERSION 1.6.0.0 (09.29.03)
Now Saves/Loads Settings!
You can now save settings, either to the default file (which will save on exit), or to a file specified. You can also load from a file. You can view settings contained in a file specified.
Added new commands for saving/loading/viewing:
/actcmd load <filename> - Will load Settings from file <filename>
(Not putting a file name will load from default file)
/actcmd save <filename> - Will save Settings to file <filename>
(Not putting a file name will save to default file)
/actcmd view <filename> - Will display Settings stored in file <filename>
SIK KeyRing Adding is faster and should work now!


---------------------------------------------------------------------------------------------

This is a macro that controls ELTank and Auto-Salvage(Which are 2 decal plugins) to aid you when you hunt salvage. You can now use it as an include file with your own macros.

You will need:
Eltank 2.6.0.1 ( Here )
U.S.T (aka Auto-Salvage) 1.0.10 ( Here )
SalvageMacroAid 1.6.0.0 ( Link Below )
SalvageMacroAid Constants 2.0 (Settings.cds) ( Link Below )

Set the constants in Settings.cds if runnign for the first time
Setup ELTank how you normally would, check the materials you want to loot.
Setup U.S.T how you want it to salvage.

When it is salvaging it will tank (stand there and take the hits) whatever is attacking you at the time. There is an HP threshold which will stop salvaging and go back to eltank. It will pause U.S.T then go back to ELTank to heal or whatever. Then when it goes back to salvaging it will resume to previous session.

---------------------------------------------------------------------------------------------

How the monsters near part of the macro works:
When the macro goes to salvage you should get a message like this:
"Waiting for tank to kill monsters before salvaging. ( 5 monsters )"
or:
"There are 0 monsters, proceeding to salvage"
This is so you dont go into the salving procedure when a respawn happens.

It is also good for when the macro will pause U.S.T beacause your health went below the $minhp. It will skip the loop where it waits for the pack to full up and goto the loop wher eit waits for mosnters in the area to be cleared.

Sometimes a monster might get stuck behind a wall if you are in a dungeon and stay there for a while and not cause harm to you. So i added ina porcedure where you can change the $near constant without stopping the macro. Type /actcmd near <number> where <number> is how many monsters around you is safe to salvage or type it with no number to set $near to how many monsters are in the area at the time.

---------------------------------------------------------------------------------------------

If you want fast support you can join me on mIRC(I'm am there most of the time): irc.sorcery.net #salvageaid

• Save both files to AC Tool/Macros/
• Set Settings.cds before you start.

---------------------------------------------------------------------------------------------

Thanks to:

Archui: for Auto-Salvage
Elgar and Cp: for Eltank

DaMOB: for the DSInventory/"Joining item with same name" procedure.
Triane: Used some of your code from a version of SpikeGolem i had on my HDD. (Time Procedure)
Slit: Added the include/standalone code which can be found in v1.4.0.0+

---------------------------------------------------------------------------------------------



Release Notes from Version 1.5.1.0 (09.28.03)
Uses a seperate file for user-defined constants, so you dont have to change them after each release. (Working on a way to be able to change these from ingame and save the settings)
Added alot of Ingame commands and options.
SIK KeyRing Adding is faster.
Breaking Due to Health slowed down.
Macro will goto salvage when there is less than the set amount set in the $near Constant

Release Notes from Version 1.5.0.0 (09.25.03)
Sturdy Iron Key adding to Ring Feature Added Beta (This hasnt been fully tested yet)
Monsters Near. Will now wait till there are $near monsters in the area before proceeding to salvage.
Breaking from Health Changed. I've rewrote this area in the macro and it will now properly pause U.S.T and turn ELTank back on and kill till there are $near monsters in the area, then it will resume salvaging. (see below for more information about this)
This version has only been tested on an archer. If you are a mage please give feedback on how it went.

Release notes From 1.4.0.0
This release now has an include feature. This is so you can include procedures in this macro into your own without heavy code editing.(Thanks to Slit)
It is turned ON by default. To use it, include this script into your own, then call the procedures as if they were part of your macro.

Release Notes From 1.3.1.1
Fixed "not combining motes" error. Will now go out of combat mode to combine them first.

Release Notes from 1.3.1.0
New Detection!!! Finally a new way for detecting when the Ust Panel is open. It uses a while _combatstate = 1 loop. Since U.S.T takes you out of combat, then returns you to combat once it has done salvaging.
Got rid of unused resolution setting code and unused commented code.

Release Notes from 1.3.0.1
Fixed Breaking Due to health code to not reset itself as soon as it sets itself.
Manually clicks the Salvage button once incase U.S.T has hung at the start.

Release Notes from 1.3.0.0
Added a universal coordinate calculation to find the area that the macro detects for when the Ust Panel is open. This now works for ANY resolution!
Cleaned up Health Threshold Code to activate only when you are salvaging and to pause/resume when the threshold is activated.
(SIK Adding has not been added to this version)

Release Notes from 1.2.2.1
I have found a bug where it will not break from salvaging when it goes below the minimum HP setting.
No new features added.

Release Notes from 1.2.2.0
Will now automatically detect your resolution and weather you have maximised chat window or not.
Resolutions Supported- Windowed: 800x600 Fullscreen: 800x600, 1024x768, 1280x1024

Release Notes from 1.2.1.1
Fixed "Procedure SetStart could not be found" error

Release Notes from 1.2.1.0 release:
Now has a Bag/Hour report when doing /actcmd status. <AcT> Full Bags: 3 ( 04.09 Bags/Hour )
Will log end session status report to file (Only if there have been 4 or more rounds)
When salvaging starts and Asherons Call is not the active window, the script will make it the active window.

Release Notes from 1.2.0.0 release:
First fully working public release.


---------------------------------------------------------------------------------------------

Plans for future releases:

Loading Different Settings per Character.

---------------------------------------------------------------------------------------------

Get Files Here!!

Salvage Macro Aid 1.6.0.0
Salvage Macro Aid Constants 2.0 (Settings.cds)

Why not just go out of combat mode to salvage while ElTank is still running? I don't see any need to pause it, hehe. Other than that, looks like an excellent, well-written script!!! Great job!!!

cos my character is an archer. so even if it is out of combat mode it will still try to kill. then it will stuff up the salvaging loop.

Also with autoloot in Eltank, sometimes you will full up halfway through looting. Keeping eltank going meant that it would still loot corpses when you salvage. This would also close the Ust Panel and end the salvaging loop.

Ran version 1.0.0.1 lastnight to make sure that bug was fixed. And this is my statistics report:
My char was only collectiong RR/CB/CS/AR salvage along with a few other general ones.

*************************************************************
Salvage Bot Statistics (Round 9) Main Pack Free Slots: 67
This Round Has taken: 09 : 48 Storing Pack Currently Pack: 4
Total Time running: 9 : 10 : 03 Storing Pack Free Slots: 10
Pyreal Motes: 2
Pyreal Sliver: 0
Pyreal Nugget: 0
Pyreal Bar: 9
*************************************************************

How has this macro worked for other people?

For me its working really well. Right now im adding in code to count full bags and give you a full bags/hour in the round statistics and adding in a log to file feature

I tryied it out today...

Still have some minor problems withe it... (trying out diffrent cfg)
But it's a great plug in so far, and when i get it to run smooth it will be AWSOME!

NEW VERSION 1.2.1.0

Now has a Bag/Hour report when doing /actcmd status. Full Bags: 3 ( 04.09 Bags/Hour )
Will log end session status report to file (Only if there have been 4 or more rounds)
When salvaging starts and Asherons Call is not the active window, the script will make it the active window.

Hm for some reason I get

"Procedure SetStart could not be found"

LOL!

yup i jsut ran into that error myself.

i renamed the setres procedure to setstart, since its doing more than setting the resolution now. Im uploading the fixed version now

Thought so lol. Works excellent except 1 problem...

When it goes to salvage it types /ust all before going out of combat mode. Then it goes out of combat mode, types it, and doesn't allow enough time to finish salvaging lol. I stuck in a delay and it works a bit better though. Soemtimes it won't combine my salvage, will only salvage it causing it to go into a neverending loop.. =/

hmm ok.

well today i had a first look at how the script goes on a mage. and he went fine for about 5 hours. then i stopped him.

and concering the looping of the salvaging procedure. the resolution setting etc isnt automatic yet....im working on it. so have you set the right one in the constants? (the problem i had was i moved the window in windowed mode and it threw the detection of the ust out).

what setting are you running? eg mage/melee/archer? resolution?

Ah, im running an archer on1024x768

I basically removed some coding (Resolution settings actually, and motes etc) and added in a few delays and it ran for 8 hrs last night. A few bugs in your initial script though.. I'm a bit confused, however, as to why it cancels the salvage process. In the dungoen I hunt at the monsters are constantly spawning but do no damage to me, but the spawn is so quick i'm getting hit as I salvage. Is that causing it to stop the process so suddenly and convert to tank? I'm taking minimal damage and I am not going below the minimum level for HP. It appears as though something is triggering it to start up tank again.. i'm not an actool genius as you can see, just tyring to explain what i'm experiencing as best I can so you can get this perfect. Btw, excellent script... I love it

It usually gets as far as salvaging the items... but that takes like 3-4 /ust doit commands... it will type /ust doit, salvage some, go into attack kill, salvage more, until its all salvaged but won't combine.

I'm having the same problem as him, except I'm running in mage mode

ok well taking out the resolution settings part will fk up the salvaging cos the detection of the ust panel relies on an isobject command which uses coordinates.

the resolution setting procedure will set the coordinates for the area it checks based on what you have set it to be @ the start of the script.

you need to set the resolution you are in manually, this is so everyone doesnt have to run in the same resolution and is more customizable. Im currently working on an auto detection that uses constants from IncUI to detect what resolution you are in.

This is where you set the resolution:

CODE

// What Resolution are you in and is it window or fullscreen?  // Right now this version only supports 800*600 windowed and 800*600/1024*768/1280*1024 fullscreen  // HAVE THE CHAT WINDOW MAXIMIZED  //  // 1 = 800*600 windowed  // 2 = 800*600 fullscreen  // 3 = 1024*768 fullscreen  // 4 = 1280*1024 fullscreen    Res                           = 1

also you shouldnt have to take out the mote parts, that is also customizable. I have that setting turned off on myne cos i got too many ingots now and its working fine.

CODE

// Do you want to loot motes? Set the next constant to 1 for yes and 2 for no  // You will also need to add Pyreal Mote into ELTank loot settings.    LootMotes                     = 0

EDIT hmm ok that mote part, the commnet says 2 for no, that should be a 0

Try changing the setting "peace mode when no target" to be on. I have this on my archer and it loots alot faster and you wont get that problem with it not going out of combat mode in time or not at all.

Severant, make sure you have the resolution set as shown above.

Everything is right ... I'll try the peace mode part, but the spawn is pretty fast

ok well peace mode when no target doesnt work for mages.

but what exactly is happening to you Severant?

is it going to salvage, then starts U.S.T, which starts IDing everything then the script will say salvaging completed then go back to killing before its done?

check: is the chat window maximized? im not sure if i have stated this, but it needs to be maximized

if you want you can PM me a screenshot of the script stuffing up.

Hm, chat wasn't maximized and I had no problems opening the ust without resolution set...

Still restarts tank before finishing salvage process =p

yes thats right it will start the salvaging process but there is code in the salvage procedure where it "pauses" the script by detecting that the ust is open using pixel coordinates. The script checks to see if the W in "WARNING...." is there.

The resolution has nothing to do with OPENING The ust is opened using "UseItem Ust, Self". When you set the resolution 1,2,3 or 4 it will then run the SetStart procedure and manually set the coordinates for where the W is going to appear on your screen based on what you have told it.

Im not sure how you are managing to salvage everyhting you get. but i salvage a mainpack at a time and it stops the loop for me before its even finished ID'ing it all if i have the chat window minimized.

Try redownloading it, setting the number that coresponds to your resolution, maximise the chat window and then try it. The current version is working perfectly for me, today i just ended a session that ran for 10 hours. i had to stop because i had no room left =\

For some reason it don't move the full bags for me.. Is there any key strokes involved in that? I have it different then the original setup.. other then that it works like a charm

The defualt settings for moving salvage to packs is for it to start on pack 2. This is what my pack layout looks like:

MAINPACK (1)
2 //starts here
3
4
5
6 // foci/comps
7 // foci/comps
8 // foci/comps

so packs 2,3,4 and 5 are for putting full bags in.

When you start the macro what does it say about the storing packs?

When it's ready to salvage, it will start iding, try to get back into mage mode, get out of mage mode, then it will repeat that untill iding is done, then it will salvage like 2 things then get back into mage mode and keeps doing that, I've had the chat not maximized and maximized, still didn't work.

Download the new version and tell me what it does.

When you start the macro it should say "Successfully set resolution to....." check to make sure this is right for your current settings.

The reason that it is doing that is because it is detecting the Ust Panel wrong, therefore it is breaking the loop and going back to killing.

I've put into the macro at the start where it tells you the coords of the part it detects and it will move the mouse there.

To test it open the ust and start the macro and dont move the mouse.

and it should look like this:



If your mouse moves here then it should run without looping

Also: When it starts ID'ing items is the ust panel open?

Note: I've left some personal code in the Setstart procedure, so i can just log in and start the macro. Since the powerbar is halfway when you login, the macro will make it full power. It will also start tank automatically.

Works now.-. thanks for the tool

Attached File ( Number of downloads: 51 )

lol. come on people i need feedback here.

is it working? is it not working? whats it doing wrong? where is it going wrong? what should i add? what should i change?

Mine is getting caught in this endless loop where it stops to salvage, but right when it opens the ust, it just ends and says salvage completed, and then tries to do it again because it didn't do anything. I messed with some delays, but that didn't work very well because it made everything take a very long time to get going, and then it still never finished everything and would do it again, taking several minutes. I am using the newest version of your script and the versions of El Tank and U.S.T. you have posted and Decal 2.5.2.0 and the newest update.

Virindi Clown. Keep your chatwindow maximized.

I haven't looked at the code but since you're doing something that requires manually defining display resolution I'd give it a shot if you added support for 1152 x 864.

ok here are somethings to remember:

• Keep the window settings you start the macro with (Maxed Chat/Not Maxed, Resolution)
• Your AC font needs to be the default (Times New Roman), i found this out when a friend of mine tried it with Arial, I will look into some new detection where letters arent used.

Jaz, ill get that resolution in the next version for you.

Vitmyr, any reason you can't use incUI or even Ipa's additional robustifier so resolutions don't need to be defined? Or am I right in guessing we're talking about Ust related coords which aren't in incUI yet?

incUI already has the ust button, and the coordinates for one of the slots -- as well as the close button.

oh cool. I didn't realise ACT 4.4.7 had been around since USTing was added to AC.

With the lastest version you dont need to define your resolution.

However i dont have a universal code that works out the coords for the detection area for every resolution. So i have to hardcode calculations for each resolution.

As i have said above, the calculations from your resolution are for the detection of the ust using IsObject. It uses a small square on the W in WARNING in the Ust Panel.



Also because it is using the text to detect it you need to be in Times New Roman, which is the font i coded the macro in. (I'm working on a new version that uses another part of the panel for detection) I originally used the Ust Panel close button for the detection, but this failed because people use different skins and changing fonts was easier than changing skins.

ANy chance you could make it add SIKs to SIK rings?

That would be great for those of us hunting olthoi

sure ill add that in a future version.

Should be interesting finding out how to detect when the keyring is full.

Probably able to see that in DSInventory[UsesLeft] or TotalUses

It's still doing it, I've tried all of your suggestions heres a chat log on what it does

<AcT> Macro STARTED via {F2} hotkey
<AcT> Resolution successfully set to 0
<AcT> 0, 0
<AcT> Starting with 0 Full Bags
<AcT> *************************************************************
<AcT> New round!(Round 1)
<AcT> Starting with 3 slots! (Salvaging When 3 Slots Left)
<AcT> Pack 7 currently assigned to storing pack with No Pack slots remaining
<AcT> *************************************************************
<AcT> Stand Clear Salvaging!
<AcT> Combining 1 Pyreal Mote.
<AcT> Combining NOT FOUND Pyreal Sliver.
<AcT> Combining NOT FOUND Pyreal Nugget.
UST: Scanning main pack.
<AcT> SALVAGING COMPLETE! Time Taken: 00 : 00 ( Bags Made: 0 )
<AcT> *************************************************************
<AcT> New round!(Round 2)
<AcT> Starting with 3 slots! (Salvaging When 3 Slots Left)
<AcT> Pack 7 currently assigned to storing pack with No Pack slots remaining
<AcT> *************************************************************
<AcT> Stand Clear Salvaging!
<AcT> Combining 1 Pyreal Mote.
<AcT> Combining NOT FOUND Pyreal Sliver.
<AcT> Combining NOT FOUND Pyreal Nugget.
<AcT> SALVAGING COMPLETE! Time Taken: 00 : 00 ( Bags Made: 0 )
<AcT> *************************************************************
<AcT> New round!(Round 3)
<AcT> Starting with 3 slots! (Salvaging When 3 Slots Left)
<AcT> Pack 7 currently assigned to storing pack with No Pack slots remaining
<AcT> *************************************************************
<AcT> Stand Clear Salvaging!
UST: Salvaging items.
UST: Salvaging stopped by player request.
UST: Salvaging failed!
<AcT> Combining 1 Pyreal Mote.
<AcT> Combining NOT FOUND Pyreal Sliver.
<AcT> Combining NOT FOUND Pyreal Nugget.
<AcT> SALVAGING COMPLETE! Time Taken: 00 : 00 ( Bags Made: 0 )

Just keeps doing that = \

ok well heres you first problem

Had it in the wrong resolution, fixed it, but it's still there. actool 4.4.7 and yes the chat is maximized

It took a bit of tweeking for me, but dam this thing rocks. I'm running it right now. 3 hours 22 bags and a few Bars.

for some reason I had to change /ust doit to /salvage doit ...it didn't take me long to find the problem. So no worries. It could have had to do with the fact I copied my old settings.xml from Auto-Salvage to UST.

SIK's will be sweet.

Thx

ok so after you changed resolution it still comes up with?:

<AcT> Resolution successfully set to 0
<AcT> 0, 0

Tonight im gonna make a start on the SIK ring adding and getting more resolutions added, or i might change the detection completely.

This is the procedure im using for the Sik ring adding.

If anyone has a better way to do this, any help would be great.

No need for all that Vit when next ACTool comes out BUT your immediate concern is your going to run into trouble.

Usesleft will constantly go down but you are forced at a max of 24 keys out of 50 at a time so it will say Usesleft 26 but you can't add more to it. Might be the other way around I forgot since I tried this last.

bah. yup i forgot about that...

you think this will work?

Nope because I have a few I use with 5 left on them and I do use them. :/ Only thing you could do is this. SelectMine Sturdy Iron Key
SetConst temp = _SelectedGUID
UseItem $temp, $SRingGUID
Loop 2
Select Self | 100
Keys E
WaitForCursor
UseItem _myid, _myid
End
LoadDecalInventory
DSFilter DSInventory, GUID = $temp
If EOF DSInventory
//Key went on
Else
//Key did not go on
End


The above waits out a lag spike and waits for the filter to update and by forcing an ID on yourself it should force an update to happen. Before the patch this worked and I was able to reduce my timer from 15 secs to 4 and probably 0 but was too scared to try. Now it probably works even better.

let me know.

ok here what i did.

to call the procedure:

Kill that Keys {ESC} and replace it with Useitem _myID, _myID

I don't use your macro nor do I play much AC these days but that inc I hope works.

Loop $temp
Inc $temp
End

Will have no effect on the times loop works but I am sure you already knew that.

ok well i changed version 1.3.0.0b to what we have worked out here.

thx for the help DaMob. Lets hope this is going to work.

im going to test the sik adding part later on when i can get ona a char with rings and siks.

Er, no it does Resolution successfully set to 800x600 blah blah, it's the right one, but still does it = \

Hmm not working out the gate for me. Getting message that it setup res etc fine. Then I get this error repeating.

<AcT> Breaking due to Health

And it never salvages anything. What did I miss?

Later

Editing my own post. Found it. My max health is below your threshold setting. Lower the threshold and am fine now.

Boy I wish this script was a function I could call form another script. I have a main script I run with El Tank. Would like to just call this script in my loop. If I get a rewrite done o fyour script can I post it?

Later

Slit, if you are meaning another ACTool script well then you can do an include @ the start of your script and then you can use the procedures in this macro as if they were part of your macro. All you need to change is the procedures that use processmessages to activate, some of these you might not want in your script. The Breaking Due to health procedure is coded badly, it uses processmessages to be activated. so if your health drops below the MINHP setting you are going to get spammed with the message. In my testing this didnt have any effects on the rest of the macro.

---------------------

Severant, well since your resolution settings are going thru maybe it is your font? Is it set to Times New Roman?

---------------------

Also has anyone tested the Sik adding feature yet? I cant test it because i used all my Sik's the other day...

---------------------

FYI: Im learning VB right now, and im reading all the documentation on making Decal Plugins. Me and my brother are in the first steps of converting this macro into a plugin. But you probably wont see it on the shelves for a couple of weeks.

Yes I meant form my AC Tool script. I figured out what I needed to do. First part was to comment out your main loop code. When I did an include command of your script it would execute that code and never return to my script. Changed it so it just does the initial setup stuff. Also had to commet out the setUi cmomands since I already had them in my script. Now just a little more and I think I got it. Rewriteing the work procedure to be a check instead of a loop, so I can call the check from my main loop. Will let you know how it goes.