hey, not to sound like a moron or anytinhg, but for some reason this macro isnt working, i have no idea why, im not a macroing noob, i had to make my own, but it doesnt keep skeles or trunks of bones, any help would ne nice, thanks

Now you can add this to your Macro since I have my Villa...

What his little snippnet of code does .. When does a /house available command.
and sounds a alarm when a Villa opens. When used with the DECAL plugin Real Estate
it supresses all the reports unless a Villa , Cottage or Mansion opens.

Install the plug in Real Estate

and do this...

add this line to your Main part of your macro under Call DetectFish

QUOTE

Call DetectVilla

then add this in to your macro...

QUOTE

Procedure DetectVilla SayPaste /house available   FindNextText Message, Villas: 1 available   If {pluginresult} <> TEXT NOT FOUND     FindTextClear SERVER     FindTextClear MESSAGE     SendText 2, Go get it!     Bell Exclamation     Delay 500     Bell Exclamation     Delay 500     Bell Exclamation     Delay 500     Bell Exclamation     End End

Try it you will like it... Ok turn off Ingame sounds at night and you will here the alarm when
it goes off.... Thats how I got my last Villa.

Happy house hunting

I was just reviewing Luv2Macro's code revision. It does a decent job of getting to the Tackle Master. I did have a problem with it repeating the attempt twice. but I stopped it before it gave him a new C note
I'll investigate why it tried.
I will do some reviewing with the time I have tonight and I'll see if I cant get a newer version with any necessary revisions posted on the front page with due credit to Luv2Macro.

You might concider making that house checker an include file, really it deserves one of its own. It's a nice idea and could be implemented in other macros as well with a simple call line.

No credit necessory.... Your code rocks.... Im a code n00b


Oh I did find for some reason if you press F2 while your toon is moving in the Nav mode it craps out ACtool.
I think this might have to do with having to call incNav2.mac for the Nav moves...

I wonder if it is bad practice to have Include lines after your constants.
I'll try it anyhow. It would save some people some error messages that dont need it.

Thanks for the compliment

Adding a new fish holding routine for those that want to keep a certain type of fish. I should have a beta out here within the hour.

Had some RL stuff to do for a while. Will be available soon.

1.5 Beta was here. 1.5.1Beta is below.

QUOTE

La-Vie-Rune, I sent you Email via this forum with a Buy Note Nav for Rithwic.

Please check your Email

QUOTE

didnt have time to figure out why it tried to buy two licenses for me

I had the same problem when I had only one
FindTextClear SERVER For some reason it did not Clear it....

I had to do this to fix it at one time, becouse it did not seem to CLEAR the Server Log

QUOTE

Procedure DetectNoLicense   //SendText 13, Debug: DetectNoLicense Called   FindText SERVER, You need a fishing license to fish here.   //SendText 13, Debug: After FindText - result = {PluginResult}   If {pluginresult} <> TEXT NOT FOUND     FindTextClear SERVER     SendText 2, Dang we need to get a Fishing License     Bell Exclamation     Delay 50     Call TackleMaster     FindTextClear SERVER     Call GiveCnote     FindTextClear SERVER     Call GotoHole     End End

I also added delays between the calls in the main part.


Oh found a Cool way to add delay for Portal space or when you need to wait for your pointer to come back from a hourglass.

QUOTE

Select Martine's Retreat   if _selected =  $Martine     delay 75     Call ChatState     Keys $Cast // this will run you to the portal     Call WaitMyCursor // pointer delay   end Procedure WaitMyCursor  // Credit: Blitzzer of WE's Spike Plat Macro   while _pointerstate <> idle     Delay 20   end end

Ok I have written 2 Nav's for 2 towns.... This one is for Yarq.

It is written as if you just sold a bunch a FISH and have called the following because some
Pyreal amount has been reached.

If you want to try this Nav start you toon standing in front of the the Tackle Master like you just turned in some fish. Press F2.

You should end up deep in the water past the last hole. This is because it was a point that can move to
any fishing hole.

This is the 2nd one, this one is for Rithwic.

It is written as if you just sold a bunch a FISH and have called the following because some
Pyreal amount has been reached.

If you want to try this Nav start you toon standing in front of the the Tackle Master like you just turned in some fish. Press F2.

You should end up in the center or the river by the bridge. This is because it was a point that can move to
any fishing hole.

I'll try out your code tonight.
btw if you look at past posts IPA posted the AcTool function call: WaitForCursor
See page 2. It even has a configurable timeout. Also one for spell timeouts. Very handy. I should put timeouts back into my code. I've barely had time to do anything recently though.

I'm currently looking into this C note error...

There are a few situations you might concider double checking as well for future reference. Perhaps the tackle master is busy with someone else and you didnt get the note to him because he was busy. It will give you a server message if he is so that is very easy to detect.
Also he says the same thing everytime after you hand him a note and your license has already expired. (he says something a little different if it hasnt yet) but its all predicatable and easily detectable.

For now I will just edit the code to see if i can clear up this error.

I may have gotten rid of it... I hope. It did seem to be a particularly evasive bug.

QUOTE

Procedure Checktown // The Procedure checks what town you selected in the setup. If $Cragstone = 1     Call CragTackleMaster     Call GiveCnote     Call CragGotoHole     FindTextClear SERVER // <--------- Here   End

I think putting your tag here is the trick for some reason. I am unsure why it would not clear it earlier but it seemed to work just now.

I havent been having any problems with the C note again.
ShoushiNav has a problem at the moment. I can fix it though. I will release a fully tested version tonight perhaps and then start working on fish sellback code.

I'll put some time into fixing this and also adding Nanto.
I dont think I'll have a new version out tonight afterall, just a beta release with new info.

Edit: Shoushi had extra coords that were wrong. Dunno how that happened.

Version of FishingFun1.5.1Beta was here. It is no longer in beta! Woohoo! Check the front for the latest version.

Any chance on a counter for 100 Bags of Salavage? and add it to the report?
Gold, Iron, Steel, Brass, Bronze, Opal, Fire Opal , Black Opal, Sunestone, Moonstone

Im not sure how hard that would be.

Let me know if you need any help with any nav coords.

I'm having fun working on your project, please feel free to PM me here...

I was thinking of adding a junk counter but I like the idea of a full bag counter instead. It's really quite easy to just report how many full bags it made and gets more complicated with more details like what bags they are etc.

Since its not terribly complicated I will add that first before I get down to anything else.

I think that the Procedure GiveCnote has an error. I currently have that part in the developmet area to verify. I tested my theory and it seems to be the case. But I need to be sure.

It is getting stuck in a Delay Loop.

QUOTE

keys $Split       delay 75       While _chatstate = True         Delay 500       End       keys 1

It is causing it to loop for ever because pressing the split key ( I think ) is just like pressing enter and going to the Chat line. so it can never get to the keys 1 line.

-------------------- EDIT----------------------------------

Yes that seems to be it.

That procedure should be changed to the following so you can buy a License

QUOTE

Procedure GiveCnote   Select $Tackle_Master   if _selected =  $Tackle_Master     delay 75     clearpluginvar _stackcount     SelectMine Trade Note (10,,000)     Delay 75     if _stackcount > 1       While _chatstate = True         Delay 500       End       keys $Split       delay 75       keys 1       delay 75       keys {return}       delay 75     end     Keys $Give     waitforcursor   else     SendText 6, I am too far away from the $Tackle_Master.   end End

This works....

Oh duh. I make some really dumb mistakes sometimes LoL.

Ok sorry guys. Ive been so focused on getting other code to work I totally skipped this one.

Note: You can save yourself the _ChatState grief *and* make your code less reliant on the user setting up the $Split Key by using a mouseclick at the left-hand-side of the quantity split bar.

This code works in all resolutions as long as the macro is using incUI:

CODE

Constants   EnterQuantity1_X = 0 End // This procedure clicks at the left hand side of the 'select quantity' // slider bar and saves you from having to map a split key or // use "keys 1" to enter a quantity of 1 to split off a stack Procedure SelectOneItemInStack    // Left-hand-side of slider bar is 24 pixels to the right of the incUI  // definition for 'EnterQuantity  Compute  $EnterQuantity1_X = $EnterQuantity_X + 24  MousePos $EnterQuantity1_X, $EnterQuantity_Y  Delay $YourMouseDelayGoesHere  LeftClick End

OK Tested this out and it seems to work really well.... i only kept the Fish and Large fish

Now to let it run for a long time to see what happens

Cannot wait for more towns, Nanto is my fav the waterfall has me

Glad it's working out well. I will try to add more towns soon. The nav code is really easy. It takes more time to test it and make it foolproof than code it really.

Ok, per your request I wrote Nanto next. I had to write a little nifty procedure to make sure the door was open. I'll be using the same thing in Holtburg to get to the mage.

I have to say is you ROCK. Thanks for the work in this macro, i wanted to check it out again this morning but my internet went down at home. No Morning AC for me today.

I will have to try it again when i get home

I’m using this for salvage and cash, but I there are a few changes that would really help.

1) can you add in giving the tackle master back title tokens? I filled up my main pack with them after 1 day. If i turn 1 in he stops giving them to me for a while when I sell fish.

2) Need to use a pyreal pack to store coins in until its time to buy. I was trying to put in some code like this

CODE

If _pyreals < 200000      MoveAllITem Pyreal, $PyrealPack, 0, 1, $PrimaryPack    End

but i was having trouble figuring out how the macro figured out what 2, 3, 4, 5, ect for the Sotre1 backpacks.
Could the macro be made so that it does not try to stack full pyreal stacks, and leave them in the pyreal storage pack when stacking after selling?


Pretty slick macro other than that. I am still amazed how far ACT has come. I started using it to make oils over 2 years ago and it was basically all blind keystrokes and delays. These Nav routines are awesome.

At one time during an alpha test I was stacking pyreal stacks in the salvage packs but then I thought that it might interfere with the salvaging routines. the big problem is that if you cannot put full bags of salvage into different packs it will try to salvage full bags with the incomplete salvage. it does not like this. in fact if you try it it will basically tell you that you cant do that. so i figured it was a higher priority to leave room for salvage.

However! I will put some code in for a seperate pack for pyreals.
I also have some new code i wrote this morning before patch hit that
1: lets you choose different note sizes (C, D, M, MD, MM, MMD) as the secondary note.
2: will check add up the total gross value of fish + pyreals already in inventory. this procedure takes a little time to calculate everything so to keep things moving smoothly i only made it available through the reporting feature.
now however it is dynamic in how often it checks to see if it is time to sell fish and buy notes. The check is done during the fish stacking procedure and it will wait for the highest stack of fish to reach either 100 or the specified number of fish is reached. this should cut down on inventory space at least a little and that all depends on what note size you choose and how many fish you are keeping.

I was also pondering having it turn the tokens in or also run to the town cryer to give the tokens away.
It wouldnt be too hard to have it give all but one so at least you would have that.
either way this will be implemented sooner or later.


as far as the packs are set: I know its a bit confusing. I tried to bring a little order to the chaos with my little stick man description. It works like this:
your main pack is number 1. you dont want to pick this pack otherwise you will be putting all your salvage right back where it came from and youll mess up the salvage routines.
the next pack down is number 2
the next pack is 3 and so on up to 8
it doesnt matter which order you specify these in the variables they are dynamically checked everytime to try to make it as foolproof as possible (in any situation try to remove the element of human error).
i.e. set pack 6, then pack 3, leave a pack set to N, then pack 5, then pack 2. it really doesnt matter as long as you have the pack number you need somewhere in the list and that number is something between 2 and 8.

I hope that helps and as soon as I have time I will be alpha testing my new code. for now I have to run to my second job.

guess i'm the only one with this issue? i setup the code and when i run it, it just sits at finding a fishing hole. Left it running for 5 minutes, still sitting there...any ideas?

oops, error on my part, ignore that.

I understood how to set it up for Salvage and how your pack scheme was working in the set up area. What I wasnt getting was how the macro knew where pack 2, 3, 4 was...I was sorta expecting mos pos coords or something to tell it where they were. I didnt think i could add:

CODE

PyrealPack = 2

and have it

CODE

If _pyreals < 200000     MoveAllITem Pyreal, $PyrealPack, 0, 1, $PrimaryPack   End

after selling. I was thinking the 2 for pack 2 needed more defination to tell it where pack 2 is.

oh...and i had to figured out that I HAD to have pack space to move full salvage the hard way. I set up a mule late at night and he had barely cleared his main pack and had no back pack space. by morning he was logged out from being full and not able to do anything. Of course i had to work so i dropped stuff on the ground and manually salvaged what I wanted...started him again then off to work. End of the day had the same prob. Once I saw why he wasnt salvaging I kicked myseld--I haddnt gotten that you would salvage all of the same material in a pack once 1 item was in the ust yet.
Anyways.......
I was relly hoping to see more advanced fishing holes with biting fish this patch...ah well.

OK i had a problem with the Door Buster code, it would select the door above me and not able to open the doors.

So I used the GUID for it and it works fine now, this macro rocks thanks.

stops salvaging and fills up with unsalvaged items quite often....lots of pack space....othr time works fine....any ideas

Toger: I will try to find a solution to that. I havent done any cross server testing for different GUID's but perhaps I will find a more accurate way to select that.

Apocolyps: hmm. Lots of pack space. Try increasing the CastDelay time in the constants. Set it to 2000 and see if that doesnt clear it up. If it helps but there is still a problem then increase the time in 500 increments.
I suspect that your connection may be a bit slower? Or perhaps you lag at just the right moment. In either case the catch detection is missing the new junk because it did not get the junk message before it went into another cast cycle.
What is your text/chat window set at? maxed or minimized?

ok....salvage problem fixed... ................. but when its time to go buy a note its say "im rich time to go buy a note " then stacks and restacks the pyreals.....Never buys a note..... Is it sussposed to go buy notes 4 u or are u sussposed to do it manually.......im in Rithwic and the licence and fish selling routine works like a charm...just not buying notes
p.s......yes i have buy the notes turned to Y

Apocolyps when this happens is your pack full. I had that problem a while ago where it kept on stacking it was due to my pack having zero slots open. Here is another few things, which fish do you keep all of them or just larger ones, How many pyreals do you have when trying to sell, where there any in extra packs

As for the door the GUID works ok for now. Here is another little issue i ran into the other night, kind of hard to repeat but when going it sell in Nanto i missed the ramp up and got stuck. So i tried to add in some code delay if i missed the second set of coords by X ammount of time go back to a few feet. But my code needs some work, it will get me unstuck but its extramly sloppy.

Oh yea i also added in an extra stop in the nav routine for Nanto, where it stops at the Town Dump and gives the tokens to him. It will drop 3 tokens in about 1 second then moves on.

Toger....no 15-20 slots open in main pack......6 emty packs......1 with salvage ....1 with ust and couple healing kits and skeleton and trunk ......i keep molies and up had 300+ K pyreals in pack 1.6.2b....the fish were already sold just parcial bags of salvage and pyreal

Strange Question What town are you fishing in?

Hey i noticed that if some one can make a macro for this then they might be able to make real decent money,listen! (Around a fishing hole there is the tackle master who sells (after u get one for free the first time) begginers guide to fishing he doesn't give u a price but he tells u to give him a few coins, if u give him one pyreal he will give you the guide everytime, i noticed that they are worth 10p and that u can get 9p when selling them in a nearby town so if u can set that up it may not be a bad macro making 8p per purchase just fill your pack and go to a near by town

Im fishing in Rithwic

Actually the problem is because hes in Rithwic. Sorry I havent had time to build note buying routines for the 4 other towns. At the moment I only have Nanto and Yaraq. For now just try running the macro in one of those two towns. I will get around to creating new nav code eventually.

Toger: I have had the same experience with IncNav2 getting stuck. I found that in 1.6.2b I may have set the accuracy radius too high on some of those nav coords. its the last number on the FastNav function call. Set all those numbers to 2 as I have now and see if it gives you trouble. I've been testing it and it seems to be ok.

QUOTE

Call FastNav -522, 816, 83.8, 28, 2

I guess thats the problem with using others macros as Includes. I dont know thier macros inside and out.

I'm getting closer to a new beta release. Until I get all the towns in I think I'll keep it that way too.

CaptianObvious: It is an idea, But, you can only hold a max of 102 items in your main inventory. In the time it takes you to give him a pyreal for each of those you could have caught a large fish worth 2000 pyreals which is more than double what you could sell all those instructions for. In the end you make more money and salvage for less effort. If it's any consolation though, I have looked over the possability before. It's just so easily dismissed.

La-Vie-Rune - Thanks for the info i will try that out.

Apocolyps
For the nav routines i have been working on one for rithwic, it seems to work fine the best part is the mage is able to be used outside, I created a new macro just to test the nav's so that is all it has in it. It goes opens the vendor selects the note and heads back to the fishing hole. Making one quick criar stop, Filling up on tokens is not fun.


Capitan - as for the book idea it would take way too long to create a profit. I found making pots will help out with the money issue, i can get a M note every 30 mins or a MMD note every 60 mins (Not sure why the math is off there but it works that way). Not too shabby. If you need money just run the macro over nite and sell the salvage for cash

Edit - Bad Spelling (I mean Really Bad spelling)

I keep hearing about potion macros to make money, but I haven’t found one in the whole macro form. I would really appreciate it if someone could post one.

I haven't did many mods to the macro since i first created it other than speeding up the pot making section. If i get some time i will rework it and possibly release it to the public. The pot macro was designed with my trade skills person in mind so its a little bit unique to my server and Trade person.

Also i have planned updates to do before its finalized, right now it requires some user controll to resetup the macro. Like restocking, it still has my old restocking code in it which works fine but i want to revamp it and some other items. Lots of stuff in mind not enough time to do it, always seems to be this way.

Last i don't think people will release too many money macro's anymore due to a fear of NERF.

Thanks for the macro, I only have 1 problem and I am sure its on my end of not putting in proper coding or not having something added, But I can not get it to salvage my items, I have changed the code from N to Y in the salvaging, the macro says done salvaging and sorting, but doesnt salvage, I have set my keyboard config. accordingly. Only thing I can figure its something to do with inc UI. mac, or Companion. inc, I added the Inc nav2.mac, is there anything you can suggest to help with not salvaging items, were I might be going wrong.

Try this version and see if it still does that.

I havent really addressed the problems that may be caused by not having your textchat bar maximized. Although this might not be the problem you are experiencing, It's about time I release the version I've been working on anyhow.

I will need to know if you see it moving the mouse at all when it does this. whether it has ever worked for you in the past and what version you were using when you experienced the problem.

I've been programming all day to get the other towns included and clean up any bugs I spot. If you see any others I may have missed dont hesitate to let me know if you think you see one. My eyes are a little tired here

Version 1.6.3 Beta is here.

It has many more features. The highlights are:
Self checks to see if it has enough fish and cash to buy notes and then runs that procedure when it does.
All towns except for Cragstone have Note Buying Routines (I have special plans for Cragstone.)
Variable note sizes are now available. (I prefer the M myself. You dont get too loaded down that way)
Various code fixes/enhancements.

Future projects: Portal recalls to buy notes and sell junk salvage. (particularly for Cragstone since its in the middle of BFE)

Report any problems please.

More info on my situation, like I said it all works good, just wont salvage the item, 4.47 actool, 2.5.0.2 decal, 1.6.2 macro, it will check the item in the pack, but the curcer will end up in the top left corner, I have tryed UI and regular, and max,min chat box (not sure what the proper setting for UI and chat box are), but anyway it wont salvage. The Y's are checked for drop junk and salvage. Ot will even say, salvaging and sorting. All keyboard configs are right, I believe I have all the other things turned off as well, "let other players give" and such. Oh ya, the salvage box is open, just not getting it there.

Is it getting the things to salvage into the ust and then not salvaging them?

I had problems with it not salvaging at first too, but found out it was because I had full bags of salvage in my main pack. After I cleared pack space and it can move full bags out of the main pack it has worked for me.

Amuk

no, its not getting them to the ust, and main pack is empty. just moves my curser to the top left and reports that it is salvaging and sorting.

Just to make sure my keyboard config is right, this is what I have

(cast) = use selected = R
(stack) = move to backpack = F

I know the others are right, just making sure these are the cast and stack options.

QUOTE

just moves my curser to the top left and reports that it is salvaging and sorting.

Your UI coordinates are off.

Are you running a skin
Are you running windowed mode

Windows, no skins