Help - Search - Members - Calendar
Full Version: Edgecom's Fishing Macro
AC Tools Everything Macro > AC Tool Macros > Final Fantasy XI Online
Pages: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
Edgecom
ok this is a public release

things the macro does

auto sort and delete fished up junk, will fight fished up monsters will auto fight agro when resting after a battle will heal to full MP and HP after a battle will use WS, JA and magic durring a fight this includes auto cure I have it setup now to start curing when your hp is in yellow to save MP ( it does not use melee when you are fight a agro only magic ) also added an option to delete certan items for ppl that can use the fished up junk will also find a fishing spot if it is unable to cast after a fight will equip a rod and bait will auto log when invintory is full or when you break your rod or run out of bait
======================================================

added ablility to log after certian number of cast in a row and you don't catch anything
also tweaked the fishing code

Latest Macro version number 4 ( 6-07-2006 ).

Name Katcher v3.5 all windows port ( or so I hope ) <-- AS OF 6-13-2006 --------

I have included all files and a readme
AS OF 7-22-2006 I am no longer supporting this version

insted please download the ffact version of me fishing macro


http://forums.cameroncole.com/index.php?showtopic=8917

Please Donate half of what ever you donate will go to AC Tool
Edgecom
o.0
Edgecom
jeust to let everyone know the current code is not the old code I tryed to get the old code to work but it did not want to work so I made a hybred of the old and the new idea I had wink.gif I am gonna tweak it a bit more before I move on to adding the ability to fight out of town and handle agro and monsters smile.gif I juat want a little feedback on the current code see if its quicker or slower smile.gif

the new code auto computes button hold down time and kinda does a random patter the catch ratio should be much better then the last few betas I released and I think for a macro that is not based off nuking the mob nor relying on rod position it has a pretty good response time
Evette
like the Macro but I have not had a chance to test it out, one thing I was wondering was if you have a Player Status memory location I added some code to and old macro to stop fishing when the Chat log displayed You have a bad / terrible... feeling about this one.

The code was simple

// ========================= Constants declarations

badfeeling = You have a bad feeling about this one.
terrible = You have a terrible feeling about this one.
positive = Your positive you don't have enough skill to reel this one in!

// ========================= Sample of the code that stops the
// ========================= fishing process

if $ffact_PlayerStatus <> 6 and $ffact_ChatAction = $terrible
call fishstop
end

if $ffact_PlayerStatus <> 6 and $ffact_ChatAction = $positive
call fishstop
end

if $ffact_PlayerStatus <> 6 and $ffact_ChatAction = $badfeeling
call fishstop
end

Looking at the macro you put together I do not see a variable declaration for Player Status I would like to be able to re add this code to the macro it saved me allot of broken rods and lost bait. Any help would be appreciated. smile.gif
Edgecom
as of now it won't break a rod it will just let the fish go at least thats how it was though out in my head o.0 although I can't say for sure cause my fishing is only lvl 16 so I haven't been able to catch higher fish.. and this code is not like the old it goes more off status and hp rather then just pushing dadadadada smile.gif and will only triggers a reel in if the fish is dead... IE targethp = 256 witch is 0hp
phillip2810
this macro works near perfectly. the only thing that stops it from being absolutely perfect is that there are a few times out of every 10 or so where is fights the fish very slowly. other than that its great.

i do have 1 question though. soon im going to be lvling up my fishing in outdoor areas. will this macro release any monsters caught? or am i going to have to babysit my character to fight them off?
Edgecom
yes but first I am tweaking the fishing code I am trying for 100% catch ratio then I will add the agro and fight moster code back in
phillip2810
edge.... i love you. lol
RiRi
Sorry for this noob reply but i'm really clueless when it comes to this.

I tried to start the marco after editing some stuffs so that it fits my own account but..

CODE

 finishaction = /logout //type the action u whish to take when finished fishing e.g. /logout if u are in the feild
 window = 1
 iamlazy = 1
 maxinvintory = 30  // Set this to your current invintory max
 mainrod = "Halycon Rod" //Set this incase somehow the rod becomes un equipped or u have more than one weaker rod ud like to use
 mainbait = "Insect Ball" //main bait to use
 casttimes = 10 //set this to the number of time it cast the line and nothing is caught will auto log you


I set these then tried to start the marco but it doesn't work, made it go into test mode to see where it hung and..

CODE

SetActiveWindow FFXiApp - Windower Enabled
DELAY: 1000
SetActiveWindow FFXiApp - Windower Enabled
TimeStamp: 04/06/2006 02:59:51:812 pm - Initialized Base Address to: 22216704 - (1530000)
SetActiveWindow FFXiApp - Windower Enabled
SetActiveWindow FFXiApp - Windower Enabled


This part kept looping..

Tried to change something below
CODE

 window1 = FFXiApp - Windower Enabled


to

CODE

 window1 = 2112 <-- example


ALthough it started working like the way the bot should but
it couldn't hit the enter button (I was using compact keyboard)

Its like it kept clicking on another window

Sorry for this dumb question but what am i suppose to replace at the top of the configuration for

window = 1

Relic
great job edge,
the macro is working nearly perfect, for me anyways. Its catching at
around 85% which is pretty good. There is one problem. Once in a WHILE,
and i do mean a while, it doesnt go into inventory and instead just constantly
presses down over and over endlessly.

This has only happened twice to be so far though so its not a big deal.
Edgecom
RiRi make sure you have ffxi set to compact keyboard mode also make sure you are using U.S. keyboard set up in windows any other keyboard setup messes up the macro
Edgecom
that invintory thing is a glitch when fishing in real laggy places I will try and fix it will try and add more delays smile.gif and also sometimes AC Tool freaks out after its been running for a long time so its a good idea to restart it when it does that
Edgecom
things I am gonna add to next beta auto current invintory number and auto max invintory set and I am looking for the memlocs for the main menu so it will check for compact mode for you and I might also add U.S. keyboard betect but not sure yet in the next beta the bot will only auto sort after catching or not catching something to cut down on the invintory scanning it will only trigger if current = max smile.gif the loop function will also go off current number so it won't over scan
jackfin
Hi all this is my first attempt at trying a macro so I decided to go to Qufim Island with Lu and Minnow (87 fishing) .... the only results are the macro will only type "/fish" every few seconds even if a fish is caught it wont fight it .. it will just continue to type "/fish".

I'm using windower
I have set keyboard to compact
changed rod and bait names
I tried moving the .MAC file around in AC tools folder

Sorry if i have missed something but i'll stay tuned here and try what I can, Thanks^^

phillip2810
you need the namechanger plugin for windower.
jackfin
ah yeah that was it ... thought that came with the latest version of windower lol

caught 2 fish right off the bat! ^^

but then on 3rd

"Something caught the hook!
You have a good feeling about this one!
Your line breaks" - macro didn't fight it ; ;

I'm not sure what went wrong but I'll get some more minnows continue with it.
Edgecom
jackfin what lvl is your fishing and where are you fishing and what are you fishing for? cause I may need to add a button cool off for harder fish
Edgecom
err crap I may know what cause the lie breakage o.0 I was fishing and noticed the fish hp hit 0 then jummped 10 points back up sad.gif so I need to add in 2 more kill button downtimes in and it should fix it

status update I am not gonna fin dthe max invintory loc its easyer just to set it before u start the macro I will how ever get the locs for the menu for auto changing of compact mode
Relic
that inventory thing i dont think is a glitch, it seems to
happen exactly everytime the line breaks, which doesnt
happen very often.

Going to try and look into the code myself and see whats going on.
Havent had time to recently though, i'll see what i can find when
I have time.
jackfin
The line breaks happened right after the fish message .. the macro didn't even get into bringing the stamina bar down.

I went back to Qufim Island with Lu and some minnows and I would catch a few then I would get a break exactly like above. I was able to catch all the fish even my targeted squids. After my last minnow I went to town and tried little worms and that worked very well except for about 1 in 12 stamina wouldn't get to zero and I would loose the catch. I didn't get any breaks in town but I would really like to fish in Qufim for squids since I am lvling off of them plus I'll be there for my next leg of lvling to 96 with black soles.
Edgecom
just uploaded beta 5 check it out on the first page biggrin.gif
Edgecom
I am looking into the line breaking problem when fishing out of towns I have to work tomorrow sat and sun. so I will only get a few min to look at it per night sad.gif but it will get fixed smile.gif
Edgecom
ok think I fixed the line breaking problem biggrin.gif but if it still breaks the line I know what to look at next also fixed not logging when you run out of bait also tweaked the fishing code a bit enjoy I gonna post it here before the first page just to see how it gonna work

ok you can find beta 6 on the first page
lavicota
it doesn't work very well ; ;

i can catch black sole by myself no problem and quite easy in fact (never get the message "you don't know how much longer blah blah blah"), but the bot won't get the fish down to even 50% ; ; /cry

good work anyway, should work perfectly with moat carp.
jackfin
Hi thanks for putting out beta6^^ I tested it for 45 min in Qufim with Lu and minnow again.

To me it works very well it just needs some tweeking=)

I got no broken lines at all.
Was able to catch every type fish.
I like that it doesn't scan for rustys after ever fish(helps with fish rate per hour).

Only problem was that when the fish would put in a little struggle the macro coudln't respond fast enough and the stamina bar would stay at same lvl or gain back about 20% and catch was lost. This happened about 1 out of 6 fish no matter what kind of fish.
Edgecom
ok cool beta 7 is gonna have the fight code in it smile.gif

I got one question though on the 1 in 6 thing did it fight the fish really slow?

lavicota what lvl are the fishing your trying for are them NF ( notours fish )? if so I think I have an new idea for the code .. to catch them but sence my lvl is only 16 it will be trial and error till its right

lavicota
my fishing level right now at 60 - black sole is capped at 93 i think, but with lu shang, you can catch them by hand, easy enough (you never run out of time to catch them).

the bot does fight it, brought it down to 65% then basically sit their till time run out.
jackfin
Well in all the fighting seemed a bit slow and on the 1 in 6 deal it just seems to loose it's groove and cant recover. It just seems that it need an adjustment to react faster.
Edgecom
ok how does the rod act when fishing for black sole do you have to move the controller or keys left and right fast or can it be held down?
lavicota
yeah i was able to hold
Edgecom
ok cool i gonna play with the numbers but i am off to work right now
Edgecom
just a status update I am about 60% done in adding the fight and agro code smile.gif should be done in a day or two even had to find a memloc for TP smile.gif err found it already

off to work I go..
Darlatan
Has anyone played with this macros to make it more effective? It isn't even catching moat carp for me at a reasoable percentage.
sean1976
you'd have to be more specific about 'effective' before could give any insight but I believe this macro is still under cinstruction so what is out there is just what Edge has so dar not the finished product. His last one before FFACT fully broke worked great so just be patient or give more specifics so we can give suggestions on your specific case.
Darlatan
well it seems to not reel in very fast even on moat carp and it seems to reel in a lot when the rod is in the middle causing the fish to gain in stamina. I mean sometimes it works great but I am probably only 50% on moat carp with 58 fishing
Edgecom
I know about this I am working on it want to get all the code back in first then I will tweak the crap out of the fishing but do to my crazy ass work schdule I am doing it as fast as I can I am gonna work on the code some more tonight before I go to sleep
Edgecom
ok status update smile.gif I got some good news I have the fight monster and the heal to full hp and mp after a fight working now I am off to bed I will release it after I have a chance to test it a bit more till then I will keep everyone up to date biggrin.gif
wilco
Why don't you use the rod position memloc that is provided by ffxi_info.inc (thank you DrewIT, Cgrinds and Rzn)? To me it seems that the left/right position works well but i am getting a strange number for the center position. You only really need the left-right position of the rod to make the fight fish function work.

I'll post my fish macro later when back from work (tweaking a bit on the fight monster macro). So far i caught about 400 moat carps with it in the last day (main + mules).

Keep up the good work.

Wilco
sean1976
you don't really need the center offsets/return value to work. Something like

while fightfish = true
If rodposition = right
keydown leftarrow
else if rodposition = left
keydown rightarrow
else
delay 100
end

forgive me for the pseudo code but I just finished like 4 assignments for C++ class and can't take the time to check specific syntax and values.

And as far as why Edgecom isn't using rod position(I didn't check if he is) I am not sure but I trust he has his reasons. My first experience with his code was his fishbot back when FFACT was still working and it was great.
wilco
Have a look at the code, its not finished yet. It requires ffxi_info.inc and alt-f9 macro setting rod, bait and fish command.
sean1976
Was there something in specific you wanted me to check? The code you have in there for rod position fighting looks like basically the same proceedure I meant with the speudocode. Looks like you have what is prolly a fairly good working fishbot there or close to if not working. A little of it seemed slightly disorganized but for personal code that is to be expected, mine looks like roadkill hash until I comment it up and organize it.
wilco
Yeah it needs some refactoring. The functionality is working: it fishes pretty quickly.

I have some questions though:
- Is there any way to stop the cycling of the window name in ffxi through the windower. The bot doesnt start sometimes due to the cycling of the window name and it cant find the memlocs then as the ffxi window couldnt get focus.
- Whats the difference between a Function and a Procedure. I cant find any reference in the Actools help to function but maybe i wasnt looking correctly
- Have you got any idea why the center fish rod is coming with a strange number (maybe i should post that in another thread)
- Have you got any experience with the FishId? I want to implement it so you can single out fish and not catch any monster.

Thanks in advance,

Wilco
cgrinds
QUOTE (wilco @ Apr 10 2006, 03:50 AM)
Yeah it needs some refactoring. The functionality is working: it fishes pretty quickly.

I have some questions though:
- Is there any way to stop the cycling of the window name in ffxi through the windower. The bot doesnt start sometimes due to the cycling of the window name and it cant find the memlocs then as the ffxi window couldnt get focus.

look for 'namechanger' plugin on the forums where you got your windower. the azaril windower has one in the forums section called 'namechanger'
QUOTE (wilco @ Apr 10 2006, 03:50 AM)
- Whats the difference between a Function and a Procedure. I cant find any reference in the Actools help to function but maybe i wasnt looking correctly

functions dont have to be 'called', and functions return a single constant as their name using the special variable 'Result'.

CODE
Function wilco
 setconst Result = Learning
end

timestamp $wilco

the test log would read 'Learning'

for the rest of your questions, i will let edgecom answer smile.gif

-cg
Edgecom
QUOTE

- Whats the difference between a Function and a Procedure. I cant find any reference in the Actools help to function but maybe i wasnt looking correctly
- Have you got any idea why the center fish rod is coming with a strange number (maybe i should post that in another thread)
- Have you got any experience with the FishId? I want to implement it so you can single out fish and not catch any monster.


- I am not sure myself what the differance is between a function and a procedure is but I will explain what I think a function is. a function is like a procedure but you do not need the call command just the constant to call it I think its maily for the decal plugin but again I am not 100% sure on this the best person to ask would be drew or cam.


- thats why I don't want to use rod position its a pain in the arse to me and SE can change to way to easy.

- no I don't target certan fish but on my memloc hunts I found a loc that had a certan number for different fish.
wilco
Edgecom thank you for the answers.

QUOTE
no I don't target certan fish but on my memloc hunts I found a loc that had a certan number for different fish


I think i saw a post that these numbers do change but they are constants for a zone so you could use it to single out fish. You just have to find the constant for the fish in the particular zone. Going to try and find out tonight

Cgrinds thank you for your explanation. I am going to check the windower site and thanks for the clear explaination of functions and procedures. I wondered how the variable Result could appear from nowhere and how you could pass results round.
Gernader8
While playing with the script, I noticed it never "searched" for the items to toss when the inventory was full. It looks like there is code there to do it because of the "If $Result = $I#."I have not seen anyone else mention this, so I thought I would point it out.

Also, excellent job so far happy.gif
Edgecom
I know I just noticed it its a code error on my part I am sorry I have fixed it I will release it with the fight code tonight I am adding something into the fight code ifrst then testing it a new beta should be uploaded in an hour or two and again sorry everyone

I am adding the ability to use just pure melee with the option to turn off magic completley and also adding the ability if you have cure enabled it will only start casting when your hp hits the halfway mark that away it saves mp and also won't keep spamming cure every 5 sec smile.gif
technolackey
i have the Beta ver.6 is that the lastest version? i was finally trying it out, (with all correct keyboard settings) and all i seem to do is nod left then it loops and nods down (in 1st person view) was looking over the code and made sure i had all the settings i believe i require...... didnt know whether or not FFact still had to be used and it does same thing....

Nvm, went to begining to re read anything i might have missed, and caught the namechange plugin part and since i refuse to play w/o windower i guess i need it smile.gif ...... cant seem to find it though, althought i am not to sure where i should be looking...
Edgecom
I will post a link where u can download the name changer plugin after I do this last test run I will upload the macro its gonna have the fight and heal code in it along with the drop item fix then my next project will be agging the agro code back in then the find spot then I will tweak the fising smile.gif err well I Am kinda doing that as I am going along but I will focus more on the fishing code after I get all the goods back in the macro smile.gif
Edgecom
the new beta is uploaded smile.gif
This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.
Invision Power Board © 2001-2010 Invision Power Services, Inc.